Fix #62 by excluding empty affected files collection #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Repo plugin adds an "empty" change log when there is a new project added or removed, e.g.: path: local/path serverPath: server/path revision: null authorName: null authorEmail: null authorDate: null committerName: null committerEmail: null committerDate: null commitText: This project was added from the manifest. modifiedFiles: null When Slack plugin tries to add the "null" affected files, it gets a NullPointerException error. Fix the error by not adding any empty affected files collection.
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
Looks OK to me. 👍 |
|
Looks good to me. |
|
I plan to release this weekend. I'm going to attempt to merge this tomorrow. |
samrocketman
added a commit
that referenced
this pull request
Mar 2, 2017
|
Feel free to subscribe to #296 for updates related to Slack Plugin 2.2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins Repo plugin adds an "empty" change log when there is a
new project added or removed, e.g.:
path: local/path
serverPath: server/path
revision: null
authorName: null
authorEmail: null
authorDate: null
committerName: null
committerEmail: null
committerDate: null
commitText: This project was added from the manifest.
modifiedFiles: null
When Slack plugin tries to add the "null" affected files, it gets a
NullPointerException error.
Fix the error by not adding any empty affected files collection.